Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(AppApi): Advanced Deploy Options for ExApps #1510

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feature(AppApi): Advanced Deploy Options for ExApps #1510

merged 2 commits into from
Oct 17, 2024

Conversation

bigcat88
Copy link
Member

This is the AppStore part of this AppAPI feature: nextcloud/app_api#406

This PR adds the ability to specify additional environment parameters, and the AppStore starts emitting information about this via an endpoint.

This is necessary because AppAPI at the stage of pressing the "Deploy and Install" button does not have the application info.xml file, and AppAPI cannot parse the information from there without downloading it - therefore we give it via the standard endpoint.

<environment-variables>
    <variable>
        <name>SOME_VALUE1</name>
        <display-name>Display name 1</display-name>
        <description>Some useful description of it</description>
    </variable>
    <variable>
        <name>SOME_VALUE2</name>
        <display-name>Display name 2</display-name>
        <description>Example of second variable with the 'default' value</description>
        <default>0</default>
    </variable>
</environment-variables>

@bigcat88 bigcat88 enabled auto-merge (squash) October 17, 2024 16:12
@bigcat88 bigcat88 merged commit 483b51e into master Oct 17, 2024
9 checks passed
@bigcat88 bigcat88 deleted the feat/appapi-deploy-env-vars branch October 17, 2024 17:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edward-ly edward-ly edward-ly approved these changes

Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigcat88 @edward-ly